Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 1/4] tracing, page-allocator: Add trace events for page allocation and page freeing | Date | Fri, 7 Aug 2009 10:17:57 +0900 (JST) |
| |
> > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > > index d052abb..843bdec 100644 > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -1905,6 +1905,7 @@ __alloc_pages_nodemask(gfp_t gfp_mask, unsigned int order, > > > zonelist, high_zoneidx, nodemask, > > > preferred_zone, migratetype); > > > > > > + trace_mm_page_alloc(_RET_IP_, page, order, gfp_mask, migratetype); > > > return page; > > > } > > > > In almost case, __alloc_pages_nodemask() is called from alloc_pages_current(). > > Can you add call_site argument? (likes slab_alloc) > > > > In the NUMA case, this will be true but addressing it involves passing down > an additional argument in the non-tracing case which I wanted to avoid. > As the stacktrace option is available to ftrace, I think I'll drop call_site > altogether as anyone who really needs that information has options.
Insted, can we move this tracepoint to alloc_pages_current(), alloc_pages_node() et al ? On page tracking case, call_site information is one of most frequently used one. if we need multiple trace combination, it become hard to use and reduce usefulness a bit.
| |