Messages in this thread Patch in this message | | | Date | Thu, 6 Aug 2009 20:01:44 -0400 (EDT) | From | Steven Rostedt <> | Subject | [GIT PULL][2.6.31] tracing: have recordmcount.pl handle a section with only weak functions |
| |
Ingo,
Please pull the latest tip/tracing/urgent tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git tip/tracing/urgent
Steven Rostedt (1): tracing: have recordmcount.pl handle a section with only weak functions
---- scripts/recordmcount.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) --------------------------- commit 0484219980fd985528f66bf620362859e617bb37 Author: Steven Rostedt <srostedt@redhat.com> Date: Thu Aug 6 19:53:18 2009 -0400
tracing: have recordmcount.pl handle a section with only weak functions Roland Dreier found that a section that contained only a weak function in one of the staging drivers and this caused recordmcount.pl to spit out a warning and fail. Although it is strange that a driver would have a weak function, and this function only be used in one place, it should not be something to make recordmcount.pl fail. This patch fixes the issue in a simple manner. If only weak functions exist in a section, than that section will not be recorded. Reported-by: Roland Dreier <rdreier@cisco.com> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index 4889c44..911ba7f 100755 --- a/scripts/recordmcount.pl +++ b/scripts/recordmcount.pl @@ -393,7 +393,7 @@ while (<IN>) { $read_function = 0; } # print out any recorded offsets - update_funcs() if ($text_found); + update_funcs() if (defined($ref_func)); # reset all markers and arrays $text_found = 0; @@ -444,7 +444,7 @@ while (<IN>) { } # dump out anymore offsets that may have been found -update_funcs() if ($text_found); +update_funcs() if (defined($ref_func)); # If we did not find any mcount callers, we are done (do nothing). if (!$opened) {
| |