lkml.org 
[lkml]   [2009]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: mmotm 2009-08-04-14-22 uploaded (ummunotify)
    Date
    Andrew, can you add this into the ummunotify patch, or add it on top or whatever?

    Fix

    ummunotify.c:(.text+0x8f217): undefined reference to `__get_user_X'

    when building for i386 -- get_user() can't handle u64 on all
    architectures, so just use copy_from_user().

    Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
    Signed-off-by: Roland Dreier <rolandd@cisco.com>
    ---
    drivers/char/ummunotify.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/char/ummunotify.c b/drivers/char/ummunotify.c
    index 725fbb0..29de6ab 100644
    --- a/drivers/char/ummunotify.c
    +++ b/drivers/char/ummunotify.c
    @@ -453,7 +453,7 @@ static long ummunotify_unregister_region(struct ummunotify_file *priv,
    struct ummunotify_reg *reg;
    int ret = -EINVAL;

    - if (get_user(user_cookie, arg))
    + if (copy_from_user(&user_cookie, arg, sizeof user_cookie))
    return -EFAULT;

    spin_lock_irq(&priv->lock);

    \
     
     \ /
      Last update: 2009-08-05 06:49    [W:0.024 / U:4.868 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site