Messages in this thread | | | Date | Wed, 05 Aug 2009 09:20:34 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev() |
| |
At Wed, 05 Aug 2009 16:11:21 +0900, Tejun Heo wrote: > > Takashi Iwai wrote: > > At Wed, 05 Aug 2009 15:35:42 +0900, > > Tejun Heo wrote: > >> [un]register_chrdev() assume minor range 0-255. This patch adds __ > >> prefixed versions which take @minorbase and @count explicitly. > >> > >> Signed-off-by: Tejun Heo <tj@kernel.org> > >> Cc: Al Viro <viro@zeniv.linux.org.uk> > >> Cc: Greg Kroah-Hartman <gregkh@suse.de> > >> --- > >> Hello, > >> > >> These two patches make sound_core grabbing OSS device number optional. > >> If there's no objection, I think it would be easiest to push this > >> through Takashi's tree. > > > > I'm fine to take this. > > > > But, I think EXPORT_SYMBOL(__register_chrdev) and > > EXPORT_SYMBOL(__unregister_chrdev) are missing in this patch. > > The only current users would be sound_core.c which is always compiled > built-in.
CONFIG_SOUND is tristate, so it can be a module. Actually SUSE kernels have it as a module :)
> Adrian would be mighty unhappy about adding EXPORT_SYMBOL() > there.
How about to replace the old *register_chrdev() with static inline, instead?
thanks,
Takashi
| |