Messages in this thread | | | From | (Eric W. Biederman) | Date | Wed, 05 Aug 2009 13:07:24 -0700 | Subject | Re: [Patch 1/7] x86: add CONFIG_KEXEC_AUTO_RESERVE |
| |
Andi Kleen <andi@firstfloor.org> writes:
> Amerigo Wang <amwang@redhat.com> writes: > >> Introduce a new config option KEXEC_AUTO_RESERVE for x86. > > The description of the feature belongs in the changelog. > > I like the basic idea, but: > >> +config KEXEC_AUTO_RESERVE >> + bool "automatically reserve memory for kexec kernel" >> + depends on KEXEC >> + default y >> + ---help--- >> + Automatically reserve memory for a kexec kernel, so that you don't >> + need to specify numbers for the "crashkernel=X@Y" boot option, >> + instead you can use "crashkernel=auto". >> + On x86, 128M is reserved. > > The obvious problem is the hardcoded 128MB (and 128MB is very large > for a crash kernel anyways) > > More useful would seem a crashkernel=size@auto
That is actually called "crashkernel=size" and we have had that for quite a while. Although some of the init scripts have problems.
Eric
| |