Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 1/2] ds2760: switch to new dev_pm_ops | Date | Wed, 5 Aug 2009 17:41:57 +0200 |
| |
On Wednesday 05 August 2009, Frans Pop wrote: > Daniel Mack wrote: > > +static struct dev_pm_ops ds2760_battery_pm_ops = { > > + .suspend = ds2760_battery_suspend, > > + .resume = ds2760_battery_resume, > > +}; > > Just to make sure... > > Have you followed the earlier discussions on dev_pm_ops conversions and > are you aware that if done like this the driver no longer supports > hibernation? > > If omitting hibernation is intentional, it should probably be justified in > the commit log. > > See http://lkml.org/lkml/2009/7/25/118 for background. > > Same goes for your patch for w1_gpio of course.
Frans, thanks for your vigilance. :-)
Daniel and everyone doing dev_pm_ops conversions or any other PM-related things, please CC your patches to linux-pm@lists.linux-foundation.org .
Best, Rafael
| |