lkml.org 
[lkml]   [2009]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v17][PATCH 16/60] pids 6/7: Define do_fork_with_pids()


Serge E. Hallyn wrote:
> Quoting Oren Laadan (orenl@librato.com):
>> From: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ...
>> +struct target_pid_set {
>> + int num_pids;
>> + pid_t *target_pids;
>> +};
>
> Oren, I thought you had decided to add an extended flags field
> here, to support additional CLONE_ flags - such as CLONE_TIMENS?

Yes.

>
> I mention it now because if you're still considering that
> long-term, then IMO the syscall should not be called clone_with_pids(),
> but clone_extended(). Otherwise, to support new clone flags we'll
> either have to use unshare2 (without clone support), or add yet
> another clone variant, OR use clone_with_pids() which is a poor name
> for something which will likely be used in cases without specifying
> pids, but specifying flags not support through any other interface.

True.

Also, Suka - any objections to rename 'struct target_pid_set' to
simply 'struct pid_set' ?
Actually, it could probably be (re)used internally in the patch that
adds to cgroup a 'procs' file similar to 'tasks'
(https://lists.linux-foundation.org/pipermail/containers/2009-July/019679.html)

Oren.



\
 
 \ /
  Last update: 2009-08-04 10:41    [W:0.334 / U:10.464 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site