lkml.org 
[lkml]   [2009]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V5 1/2] introduce ALS sysfs class
On Mon 2009-08-31 16:48:57, Zhang Rui wrote:
> On Mon, 2009-08-31 at 16:34 +0800, Pavel Machek wrote:
> > Hi!
> >
> > > @@ -0,0 +1,32 @@
> > > +What: /sys/class/als/als[0-N]/desc
> > > +Date: Aug. 2009
> > > +KernelVersion: 2.6.32
> > > +Contact: Zhang Rui <rui.zhang@intel.com>
> > > +Description: Strings which descibes the current Ambient Light Sensor
> > > + device. This is given by native ALS driver as part of
> > > + registration. e.g: "acpi_als" for ACPI ALS devices.
> > > + RO
> >
> > Normal way to do that (backlight class does it, for example) is to
> > have acpi_als instead of als0, and get rid of desc field.
>
> IMO, both are okay, hard to say which is preferred.
> Other sysfs classes like scsi_host, hwmon, input use this as well.
> and you don't have a really strong objection to this, right? :)

Actually I do. Inventing nonsensical als17 name, then having helpful
desc explaining it is acpi_als is pretty ugly...
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-08-31 11:05    [W:0.035 / U:10.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site