lkml.org 
[lkml]   [2009]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 0/4] memcg: add support for hwpoison testing
On Mon, 31 Aug 2009 18:26:40 +0800
Wu Fengguang <fengguang.wu@intel.com> wrote:

> Hi all,
>
> In hardware poison testing, we want to inject hwpoison errors to pages
> of a collection of selected tasks, so that random tasks (eg. init) won't
> be killed in stress tests and lead to test failure.
>
> Memory cgroup provides an ideal tool for tracking and testing these target
> process pages. All we have to do is to
> - export the memory cgroup id via cgroupfs
> - export two functions/structs for hwpoison_inject.c
>
> This might be an unexpected usage of memory cgroup. The last patch and this
> script demonstrates how the exported interfaces are to be used to limit the
> scope of hwpoison injection.
>
> test -d /cgroup/hwpoison && rmdir /cgroup/hwpoison
> mkdir /cgroup/hwpoison
>
> usemem -m 100 -s 100 & # eat 100MB and sleep 100s
> echo `pidof usemem` > /cgroup/hwpoison/tasks
>
> ==> memcg_id=$(</cgroup/hwpoison/memory.id)
> ==> echo $memcg_id > /debug/hwpoison/corrupt-filter-memcg
>
> # hwpoison all pfn
> pfn=0
> while true
> do
> let pfn=pfn+1
> echo $pfn > /debug/hwpoison/corrupt-pfn
> if [ $? -ne 0 ]; then
> break
> fi
> done
>

I don't like this.

1. plz put all under CONFIG_DEBUG_HWPOISON or some
2. plz don't export memcg's id. you can do it without it.
3. If I was you, just adds following file

memory.hwpoison_test
Then, if you allow test
#echo 1 > memory.hwpoison_test

4. I can't understand why you need this. I wonder you can get pfn via
/proc/<pid>/????. And this may insert HWPOISON to page-cache of shared
library and "unexpected" process will be poisoned.

Thanks,
-Kame

> Comments are welcome, thanks!
>
> Cheers,
> Fengguang
> --
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>



\
 
 \ /
  Last update: 2009-09-01 01:51    [W:0.068 / U:7.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site