lkml.org 
[lkml]   [2009]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: remove mentioning of legacy latency_trace file from documentation
On Mon, Aug 31, 2009 at 09:08:54PM +0200, Frederic Weisbecker wrote :
> On Mon, Aug 31, 2009 at 08:50:35PM +0200, Albin Tonnerre wrote:
> >
> > @@ -307,8 +299,8 @@ the lowest priority thread (pid 0).
> > Latency trace format
> > --------------------
> >
> > -For traces that display latency times, the latency_trace file
> > -gives somewhat more information to see why a latency happened.
> > +For traces that display latency times, the trace file gives
> > +somewhat more information to see why a latency happened.
>
>
>
> Hmm, now that the latency_trace file has disappeared, this sentence
> doesn't make sens anymore.
> The trace file gives more information about latency than...? :-)
>
> Actually the latency format still exists.
> It's toggable through the latency-format trace option:
>
> echo latency-format > trace_options
>
> I guess this documentation should actually not make the latency
> format documentation disappear but actually mirror the moving from
> a file to an option.

Right, I'll do that. Actually this patch doesn't really make it disappear, as
the format is still described here. I agree that the above paragraph should be
rephrased to mention that i's available through the latency-format option.

> > delay: This is just to help catch your eye a bit better. And
> > needs to be fixed to be only relative to the same CPU.
> > @@ -440,7 +432,8 @@ Here are the available options:
> > sym-addr:
> > bash-4000 [01] 1477.606694: simple_strtoul <c0339346>
> >
> > - verbose - This deals with the latency_trace file.
> > + verbose - This deals with the trace file when it
> > + displays lantecy times.
>
>
> "latency"

thanks

> Is it true when latency-format is not selected?

No, it only applies when latency-format is selected.

Regards,
--
Albin Tonnerre, Free Electrons
Kernel, drivers and embedded Linux development,
consulting, training and support.
http://free-electrons.com


\
 
 \ /
  Last update: 2009-08-31 21:49    [W:0.050 / U:1.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site