lkml.org 
[lkml]   [2009]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: xfs compat_ioctl?
    On Mon, Aug 31, 2009 at 08:14:58PM +0200, Torsten Kaiser wrote:
    > On a slightly related note: I also have a system with a 32bit userland
    > and a 64bit kernel.
    > After switching to the 64bit kernel, xfs_fsr was no longer working,
    > but that was caused by the then still missing compat ioctls.
    >
    > Today I retried it, but it still fails:
    > XFS_IOC_SWAPEXT failed: ino=<number>: Invalid argument
    >
    > Looking at the compat code SWAPEXT looks somewhat suspicious:
    >
    > fs/xfs/linux-2.6/xfs_ioctl32.h defines XFS_IOC_SWAPEXT_32, but I can't
    > find a single place where this is used.
    > And in the big switch of xfs_compat_ioctl() the value XFS_IOC_SWAPEXT
    > is surrounded by contants that all end in 32.
    >
    > I don't have any experience with the linux ioctl code, I only read
    > fs/xfs/linux-2.6/xfs_ioctl32.c, but for my untrained eye it looks like
    > there is a _32 missing.
    >
    > Or am I misreading this completely?

    I think you are right, the constant used is incorrect. Does the small
    patch below fix it for you?

    Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c
    ===================================================================
    --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:06.093044591 -0300
    +++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl32.c 2009-08-31 15:25:10.856544216 -0300
    @@ -619,7 +619,7 @@ xfs_file_compat_ioctl(
    case XFS_IOC_GETVERSION_32:
    cmd = _NATIVE_IOC(cmd, long);
    return xfs_file_ioctl(filp, cmd, p);
    - case XFS_IOC_SWAPEXT: {
    + case XFS_IOC_SWAPEXT_32: {
    struct xfs_swapext sxp;
    struct compat_xfs_swapext __user *sxu = arg;


    \
     
     \ /
      Last update: 2009-08-31 20:31    [W:0.020 / U:60.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site