| Date | Mon, 31 Aug 2009 11:27:11 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH 13/23] io-controller: Separate out queue and data |
| |
Vivek Goyal wrote: > o So far noop, deadline and AS had one common structure called *_data which > contained both the queue information where requests are queued and also > common data used for scheduling. This patch breaks down this common > structure in two parts, *_queue and *_data. This is along the lines of > cfq where all the reuquests are queued in queue and common data and tunables > are part of data. > > o It does not change the functionality but this re-organization helps once > noop, deadline and AS are changed to use hierarchical fair queuing. > > o looks like queue_empty function is not required and we can check for > q->nr_sorted in elevator layer to see if ioscheduler queues are empty or > not. > > Signed-off-by: Nauman Rafique <nauman@google.com> > Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
|