lkml.org 
[lkml]   [2009]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH mmotm] vfs: optimize touch_time too fix
Recent mmotms give me WARNING: at fs/namespace.c:612 mntput_no_expire()+...
when unmounting: __mntput()'s WARN_ON(count_mnt_writers(mnt)).

That's because vfs-optimize-touch_time-too.patch inverted the sense
of mnt_want_write_file(), which is error-returning, not a boolean.

Presumably filetime updates went missing too, but I didn't notice those.

Signed-off-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
---

fs/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- mmotm/fs/inode.c 2009-08-28 10:07:56.000000000 +0100
+++ linux/fs/inode.c 2009-08-31 14:08:24.000000000 +0100
@@ -1481,7 +1481,7 @@ void file_update_time(struct file *file)
return;

/* Finally allowed to write? Takes lock. */
- if (!mnt_want_write_file(file))
+ if (mnt_want_write_file(file))
return;

/* Only change inode inside the lock region */

\
 
 \ /
  Last update: 2009-08-31 17:11    [W:0.042 / U:16.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site