Messages in this thread Patch in this message | | | Date | Mon, 31 Aug 2009 15:02:09 +0200 | From | Andreas Herrmann <> | Subject | [PATCH 5/5] x86, mcheck: Make use of cpu_node_mask instead of cpu_core_mask |
| |
This fixes threshold_bank4 support on multi-node processors.
We need to create 2 sets of symlinks for sibling shared banks -- one set for each internal node, symlinks of each set should target the first core on same internal node.
Currently only one set is created where all symlinks are targeting the first core of the entire socket.
Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com> --- arch/x86/kernel/cpu/mcheck/mce_amd.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce_amd.c b/arch/x86/kernel/cpu/mcheck/mce_amd.c index ddae216..595cbe5 100644 --- a/arch/x86/kernel/cpu/mcheck/mce_amd.c +++ b/arch/x86/kernel/cpu/mcheck/mce_amd.c @@ -494,7 +494,7 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank) #ifdef CONFIG_SMP if (cpu_data(cpu).cpu_core_id && shared_bank[bank]) { /* symlink */ - i = cpumask_first(cpu_core_mask(cpu)); + i = cpumask_first(cpu_node_mask(cpu)); /* first core not up yet */ if (cpu_data(i).cpu_core_id) @@ -514,7 +514,7 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank) if (err) goto out; - cpumask_copy(b->cpus, cpu_core_mask(cpu)); + cpumask_copy(b->cpus, cpu_node_mask(cpu)); per_cpu(threshold_banks, cpu)[bank] = b; goto out; @@ -539,7 +539,7 @@ static __cpuinit int threshold_create_bank(unsigned int cpu, unsigned int bank) #ifndef CONFIG_SMP cpumask_setall(b->cpus); #else - cpumask_copy(b->cpus, cpu_core_mask(cpu)); + cpumask_copy(b->cpus, cpu_node_mask(cpu)); #endif per_cpu(threshold_banks, cpu)[bank] = b; -- 1.6.4
| |