lkml.org 
[lkml]   [2009]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] use __pa_symbol to calculate the address of a C symbol.
On 08/31/2009 10:04 AM, Glauber Costa wrote:
> The use of __pa() to calculate the address of a C-visible symbol
> is wrong, and can lead to unpredictable results. See arch/x86/include/asm/page.h
> for details.
>
> It should be replaced with __pa_symbol(), that does the correct math here,
> by taking relocations into account.
>

Applied, thanks.

I note that the changelog entry says nothing about what component is
involved and what the effect of the bug is. This reduces its usefulness
for someone looking over the log and trying to see if a particular bug
is fixed.

--
error compiling committee.c: too many arguments to function



\
 
 \ /
  Last update: 2009-08-31 13:27    [from the cache]
©2003-2011 Jasper Spaans