[lkml]   [2009]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ata_piix: parallel scanning on PATA needs an extra locking
On Sunday 30 August 2009 16:13:21 Alan Cox wrote:
> > Lets fix all such races by adding an extra locking to ->set_piomode
> > and ->set_dmamode methods for PATA controllers.
> Would it not be better to take the host lock in libata-core for these
> cases so that we fix all the adapters in one swoop. Even if we are doing
> this lock taking in the controller specific code it seems the right lock
> to use ?

Yes, taking the host lock would be a preferred solution in the long-term
and would allow us to enable parallel scanning for many other controllers

The downside is that it requires somebody to audit all host drivers before
making such change and much more testing time..

> Looks fine as a temproary quickfix tho

That was the goal of the patch (I verified the issue only yesterday).

 \ /
  Last update: 2009-08-30 16:35    [W:0.023 / U:32.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site