lkml.org 
[lkml]   [2009]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Fix proc_file_write missing ppos update
On Sat, Aug 29, 2009 at 07:16:50PM -0400, Christoph Hellwig wrote:
> On Sat, Aug 29, 2009 at 06:38:12PM +0200, Stefani Seibold wrote:
> > The following fix a long standing issue in the proc_file_write function,
> > which doesn't update the ppos file position pointer.
>
> The right fix is to get rid of the last remaining
> read_proc_t/write_proc_t instances and switch everyone to implement file
> operations. Alexey has been working on this on and off for a while.

Yes, please, ->write_proc is going to end very soon.

As for prevoius arguments:
- changing ->write_proc signature is _of course_ going to break
out-of-tree stuff
- ->proc_fops worked since forever, and since it's struct file_operations,
nobody prohibits implementing ->write with pos update and what not.
- seq_file is not relevant to this issue because seq_file is for read path
only.

Back into SCSI pile of users.


\
 
 \ /
  Last update: 2009-08-30 10:13    [W:0.055 / U:3.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site