lkml.org 
[lkml]   [2009]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm: use proc_create_data()

> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

I pushed a slightly modified version to drm-next, it moves the
filling out of tmp before the data create.

Thanks,
Dave.

> ---
>
> drivers/gpu/drm/drm_proc.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> --- a/drivers/gpu/drm/drm_proc.c
> +++ b/drivers/gpu/drm/drm_proc.c
> @@ -106,7 +106,8 @@ int drm_proc_create_files(struct drm_info_list *files, int count,
> continue;
>
> tmp = kmalloc(sizeof(struct drm_info_node), GFP_KERNEL);
> - ent = create_proc_entry(files[i].name, S_IFREG | S_IRUGO, root);
> + ent = proc_create_data(files[i].name, S_IRUGO, root,
> + &drm_proc_fops, tmp);
> if (!ent) {
> DRM_ERROR("Cannot create /proc/dri/%s/%s\n",
> name, files[i].name);
> @@ -115,8 +116,6 @@ int drm_proc_create_files(struct drm_info_list *files, int count,
> goto fail;
> }
>
> - ent->proc_fops = &drm_proc_fops;
> - ent->data = tmp;
> tmp->minor = minor;
> tmp->info_ent = &files[i];
> list_add(&(tmp->list), &(minor->proc_nodes.list));
>
>


\
 
 \ /
  Last update: 2009-08-31 01:41    [W:0.030 / U:9.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site