lkml.org 
[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] venet: add scatter-gather/GSO support
    Stephen Hemminger wrote:
    > On Mon, 03 Aug 2009 13:18:07 -0400
    > Gregory Haskins <ghaskins@novell.com> wrote:
    >
    >> + struct {
    >> + int sg:1;
    >> + int tso:1;
    >> + int ufo:1;
    >> + int tso6:1;
    >> + int ecn:1;
    >> + } flags;
    >
    > Why do you have to shadow flags that are already available in net_device?
    > It is bad design to replicate state in a device driver. The problem
    > with replicated state is that it has to be updated in both places.
    >

    Ya, you are right. I think the rationale was that the flags were "hw"
    state, whereas dev->features was software state. But thinking about it
    after you comments, I don't think it makes much difference either way.

    I will just have the negcap() function set the features directly in v2.

    Kind Regards,
    -Greg

    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2009-08-03 22:01    [W:2.618 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site