[lkml]   [2009]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: WARNING at: drivers/char/tty_ldisc.c
    > it. But, even before the patch, it seems we didn't
    > filp->f_op = &hung_up_tty_fops;
    > for console stuff. But, I'm still not found why we avoid to the above...

    Not sure - I'd have to re-read all the specs. Could be that applications
    writing to the console do not expect to get a hangup when the device for
    the console ceases to be a controlling terminal. That would be a
    behaviour change. Equally if we don't set the hung_up file operations we
    can't call ->hangup().

    I'd be very concerned about having the console behaviour changed. For a
    late -rc I'd think it may even be better to leak an ldisc instance in
    that case providing end users can't cause a repeated leak of that form.

    (ie if its got a use count when we got to free it we just look the other
    way or queue the kfree)

    The more I look at this the more risky all the changes look except for
    switching it to refcount properly.

    We risk changing the behaviour of consoles in ways that might break apps
    and certainly break our behaviour. We end up risking messing up serial
    consoles and trying to printk to down devices.

    Proper refcounting on the other hand fixes the real problem in a
    controlled fashion without hard to analyse and define behaviour changes.


     \ /
      Last update: 2009-08-03 19:01    [W:0.018 / U:5.936 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site