lkml.org 
[lkml]   [2009]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] SR-IOV: correct broken resource alignment calculations
    * Greg KH (greg@kroah.com) wrote:
    > On Fri, Aug 28, 2009 at 12:17:14PM -0700, Chris Wright wrote:
    > > An SR-IOV capable device includes an SR-IOV PCIe capability which
    > > describes the Virtual Function (VF) BAR requirements. A typical SR-IOV
    > > device can support multiple VFs whose BARs must be in a contiguous region,
    > > effectively an array of VF BARs. The BAR reports the size requirement
    > > for a single VF. We calculate the full range needed by simply multiplying
    > > the VF BAR size with the number of possible VFs and create a resource
    > > spanning the full range.
    > >
    > > This all seems sane enough except it artificially inflates the alignment
    > > requirement for the VF BAR. The VF BAR need only be aligned to the size
    > > of a single BAR not the contiguous range of VF BARs. This can cause us
    > > to fail to allocate resources for the BAR despite the fact that we
    > > actually have enough space.
    > >
    > > This patch adds a support for a new resource alignment type,
    > > IORESOURCE_VSIZEALIGN, and allows struct resource to keep track of the
    > > size requirements of a VF BAR which are smaller than the full resource
    > > size. This could also be done all within the PCI layer w/out bloating
    > > struct resource or using the last available bit for alignment types.
    > >
    > > Comments?
    > >
    > > Signed-off-by: Chris Wright <chrisw@sous-sol.org>
    > > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
    > > Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
    > > Cc: Linus Torvalds <torvalds@linux-foundation.org>
    > > Cc: Matthew Wilcox <matthew@wil.cx>
    > > Cc: Yu Zhao <yu.zhao@intel.com>
    > > Cc: stable@kernel.org
    >
    > This is a new feature, which seems to be odd to have it sent to stable
    > :)

    Yeah, it's broken now (and shipped in 2.6.30).

    > Does this fix reported problems in the "wild"?


    Depending on card firwmware, yeah, I've hit this problem.


    thanks,
    -chris


    \
     
     \ /
      Last update: 2009-08-28 22:03    [W:0.026 / U:151.372 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site