Messages in this thread Patch in this message | | | Date | Thu, 27 Aug 2009 17:41:06 +0900 | From | Jin Dongming <> | Subject | [PATCH] x86, mce: reset kernel for no-match exception errors |
| |
The last case of severity table is used for no match exception error. Maybe such kind of error could not happen. But I think when the error really happened, the kernel should be reset. Because such error is unknown and unexpected. So I make this patch for fixing this problem.
This patch is based on tip/x86/mce.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com> --- arch/x86/kernel/cpu/mcheck/mce-severity.c | 2 +- arch/x86/kernel/cpu/mcheck/mce.c | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce-severity.c b/arch/x86/kernel/cpu/mcheck/mce-severity.c index bc35a07..092755b 100644 --- a/arch/x86/kernel/cpu/mcheck/mce-severity.c +++ b/arch/x86/kernel/cpu/mcheck/mce-severity.c @@ -97,7 +97,7 @@ static struct severity { "Action optional with lost events", SER), BITSET(MCI_STATUS_UC|MCI_STATUS_OVER, PANIC, "Overflowed uncorrected"), BITSET(MCI_STATUS_UC, UC, "Uncorrected"), - BITSET(0, SOME, "No match") /* always matches. keep at end */ + BITSET(0, PANIC, "Unknown Error") /* always matches. keep at end */ }; /* diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 2c3bcd1..cc6e9cb 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -245,6 +245,12 @@ static void mce_panic(char *msg, struct mce *final, char *exp) struct mce *m = &mcelog.entry[i]; if (!(m->status & MCI_STATUS_VAL)) continue; + /* + * When no-match error happened, it is a corrected error and + * logged as final one. Prevents it from being printed twice. + */ + if (final && !memcmp(m, final, sizeof(struct mce))) + continue; if (!(m->status & MCI_STATUS_UC)) print_mce(m); } -- 1.6.2.2
| |