lkml.org 
[lkml]   [2009]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH]: tracing: s390 arch updates for tracing syscalls
    On Wed, Aug 26, 2009 at 06:53:25PM +0200, Frederic Weisbecker wrote:
    > > Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
    > > ---
    > > arch/s390/include/asm/ftrace.h | 4 ++++
    >
    > Btw, the stat have changes in ftrace.h but your patch haven't.
    > Is there something missing?
    No. diffstat has not been refreshed after removing the
    FTRACE_SYSCALL_MAX constant.
    Here is the patch again with the refreshed diffstat:

    Syscall tracing updates for s390 architecture.

    This patch includes s390 arch updates for:
    - tracing: Map syscall name to number (syscall_name_to_nr())
    - tracing: Call arch_init_ftrace_syscalls at boot
    - tracing: add support traceopint ids (set_syscall_{enter,exit}_id())

    Signed-off-by: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
    ---
    arch/s390/kernel/ftrace.c | 36 +++++++++++++++++++++++++++---------
    1 file changed, 27 insertions(+), 9 deletions(-)

    --- a/arch/s390/kernel/ftrace.c
    +++ b/arch/s390/kernel/ftrace.c
    @@ -220,6 +220,29 @@ struct syscall_metadata *syscall_nr_to_m
    return syscalls_metadata[nr];
    }

    +int syscall_name_to_nr(char *name)
    +{
    + int i;
    +
    + if (!syscalls_metadata)
    + return -1;
    + for (i = 0; i < NR_syscalls; i++)
    + if (syscalls_metadata[i])
    + if (!strcmp(syscalls_metadata[i]->name, name))
    + return i;
    + return -1;
    +}
    +
    +void set_syscall_enter_id(int num, int id)
    +{
    + syscalls_metadata[num]->enter_id = id;
    +}
    +
    +void set_syscall_exit_id(int num, int id)
    +{
    + syscalls_metadata[num]->exit_id = id;
    +}
    +
    static struct syscall_metadata *find_syscall_meta(unsigned long syscall)
    {
    struct syscall_metadata *start;
    @@ -237,24 +260,19 @@ static struct syscall_metadata *find_sys
    return NULL;
    }

    -void arch_init_ftrace_syscalls(void)
    +static int __init arch_init_ftrace_syscalls(void)
    {
    struct syscall_metadata *meta;
    int i;
    - static atomic_t refs;
    -
    - if (atomic_inc_return(&refs) != 1)
    - goto out;
    syscalls_metadata = kzalloc(sizeof(*syscalls_metadata) * NR_syscalls,
    GFP_KERNEL);
    if (!syscalls_metadata)
    - goto out;
    + return -ENOMEM;
    for (i = 0; i < NR_syscalls; i++) {
    meta = find_syscall_meta((unsigned long)sys_call_table[i]);
    syscalls_metadata[i] = meta;
    }
    - return;
    -out:
    - atomic_dec(&refs);
    + return 0;
    }
    +arch_initcall(arch_init_ftrace_syscalls);
    #endif

    \
     
     \ /
      Last update: 2009-08-27 09:31    [W:0.028 / U:32.964 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site