lkml.org 
[lkml]   [2009]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix book E watchdog to take WDIOC_SETTIMEOUT arg in seconds
Hi Josh,

> >Now we only need someone that can look at the CONFIG_4xx cases still :-)
>
> It seems the FSL watchdog is much more flexible than the one found in 4xx
> cores. On 4xx, you basically have 4 static choices that represent specific
> times determined by the clock frequency. I'm concerned that the lack of
> granularity here will result in less than desirable behavior.
>
> For example, with a 400MHz clock you would get choices of roughly:
>
> 5.2 ms
> 83.9 ms
> 1.34 s
> 21.47 s
>
> Personally, I consider the first two options basically unusable. Considering
> the second two, if a user were to say "Set the timeout for 2 seconds" they
> would then get a timeout of 21 seconds with the framework Chris' patch has
> set up. That doesn't really seem to be ideal to me.

Hmm, my opinion: in that case we should use a timer that triggers the watchdog until userspaces times out (like we do for other watchdogs allready). Maybe we should split this driver. I have the same issue with the Freescale i.mx driver that is under review also.

Kind regards,
Wim.



\
 
 \ /
  Last update: 2009-08-27 22:29    [W:0.042 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site