Messages in this thread | | | Date | Thu, 27 Aug 2009 14:47:12 +0200 | From | Andreas Herrmann <> | Subject | Re: [PATCH 8/15] sched: Add parameter sched_mn_power_savings to control MN domain sched policy |
| |
On Wed, Aug 26, 2009 at 03:00:43PM +0530, Gautham R Shenoy wrote: > Hi Andreas, > > On Thu, Aug 20, 2009 at 03:39:14PM +0200, Andreas Herrmann wrote: > > @@ -9208,6 +9229,11 @@ int __init sched_create_sysfs_power_savings_entries(struct sysdev_class *cls) > > err = sysfs_create_file(&cls->kset.kobj, > > &attr_sched_mc_power_savings.attr); > > #endif > > +#ifdef CONFIG_SCHED_MN > > + if (!err && mc_capable()) > > + err = sysfs_create_file(&cls->kset.kobj, > > + &attr_sched_mn_power_savings.attr); > > +#endif > > This would create the sysfs tunable even on systems which are > mc_capable() but don't have multi-nodes on a package, no ?
Yes, that is a bug. I should have introduced mn_capable() to create this file only if really required.
Thanks, Andreas
-- Operating | Advanced Micro Devices GmbH System | Karl-Hammerschmidt-Str. 34, 85609 Dornach b. München, Germany Research | Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis München (OSRC) | Registergericht München, HRB Nr. 43632
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |