Messages in this thread | | | Date | Wed, 26 Aug 2009 10:22:22 +0400 | Subject | Re: [rfc -tip 3/4] x86,apic: fix missed handling of discrete apics | From | Cyrill Gorcunov <> |
| |
On 8/26/09, Ingo Molnar <mingo@elte.hu> wrote: > > * Cyrill Gorcunov <gorcunov@openvz.org> wrote: > >> + if (!cpu_has_apic && (!smp_found_config || disable_apic)) >> + if (!cpu_has_apic && (!smp_found_config || disable_apic)) >> + if (cpu_has_apic || (smp_found_config && !disable_apic)) > > these are now repeating patterns, so that should be moved into a > helper inline or so. > > Ingo > Absolutely yes. Though i didn't invent more or less convenient name for this helper. lapic_from_mp perhaps. Have to think. Thanks for review, Ingo!
| |