Messages in this thread Patch in this message | | | Date | Wed, 26 Aug 2009 08:15:44 GMT | From | "tip-bot for Paul E. McKenney" <> | Subject | [tip:core/rcu] rcu: Remove lockdep annotations from RCU's _notrace() API members |
| |
Commit-ID: 06e799764eb7c2e4640888d438c3524d756613e1 Gitweb: http://git.kernel.org/tip/06e799764eb7c2e4640888d438c3524d756613e1 Author: Paul E. McKenney <paulmck@linux.vnet.ibm.com> AuthorDate: Tue, 25 Aug 2009 18:53:37 -0700 Committer: Ingo Molnar <mingo@elte.hu> CommitDate: Wed, 26 Aug 2009 09:45:41 +0200
rcu: Remove lockdep annotations from RCU's _notrace() API members
The lockdep annotations rcu_read_acquire() and rcu_read_release() might lead to infinite looping if called from lockdep. So this patch removes them. Formal repost of http://lkml.org/lkml/2009/8/25/309 on the strength of Lai Jiangshan's review.
Suggested-by: Lai Jiangshan <laijs@cn.fujitsu.com> Suggested-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> Reviewed-by: Lai Jiangshan <laijs@cn.fujitsu.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Cc: dipankar@in.ibm.com Cc: akpm@linux-foundation.org Cc: josht@linux.vnet.ibm.com Cc: dvhltc@us.ibm.com Cc: niv@us.ibm.com Cc: peterz@infradead.org Cc: rostedt@goodmis.org LKML-Reference: <20090826015337.GA18904@linux.vnet.ibm.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
--- include/linux/rcupdate.h | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/include/linux/rcupdate.h b/include/linux/rcupdate.h index 8b4422c..95e0615 100644 --- a/include/linux/rcupdate.h +++ b/include/linux/rcupdate.h @@ -195,7 +195,6 @@ static inline notrace void rcu_read_lock_sched_notrace(void) { preempt_disable_notrace(); __acquire(RCU_SCHED); - rcu_read_acquire(); } /* @@ -211,7 +210,6 @@ static inline void rcu_read_unlock_sched(void) } static inline notrace void rcu_read_unlock_sched_notrace(void) { - rcu_read_release(); __release(RCU_SCHED); preempt_enable_notrace(); }
| |