Messages in this thread | | | Date | Tue, 25 Aug 2009 06:57:07 -0400 | From | Neil Horman <> | Subject | Re: [PATCH 1/2] trace_events: fix napi's tracepoint |
| |
On Tue, Aug 25, 2009 at 09:58:16AM +0200, Ingo Molnar wrote: > > * Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> wrote: > > > Currently, the napi's tracepoint works will is depend on > > "DECLARE_TRACE" definiens in include/trace/define_trace.h, > > like below: > > > > #include <trace/events/skb.h> // include define_trace.h > > #include <trace/events/napi.h> > > > > there have error, if we remove "#include <trace/events/skb.h>" > > or include napi.h in the front of include skb.h, It should > > depend on the definiens in include/linux/tracepoint.h and we > > can remove the "DECLARE_TRACE" definiens in > > include/trace/define_trace.h, because "TRACE_EVENT" not use it > > > > Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> > > --- > > include/trace/define_trace.h | 4 ---- > > net/core/net-traces.c | 4 +++- > > 2 files changed, 3 insertions(+), 5 deletions(-) > > This will collide with tracing bits in the networking tree. The > skb-tracing plugin there should be turned into proper TRACE_EVENT() > tracepoints. > > Neil was away for some time but i think soon we should see some > movement here. > > Ingo >
Thank you Ingo, yes, I'm back from the beach now and will look at this shortly. I concur, we should just convert the napi_poll tracepoint to be defined via the TRACE_EVENT macro, same as the kfree_skb tracepoint. Xaio would you like to take care of that, or shall I?
Best Neil
| |