Messages in this thread | | | Date | Mon, 24 Aug 2009 09:58:03 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 1/4] direct-io: unify argument passing by adding a dio_args structure |
| |
On Thu, Aug 20 2009, Andrew Morton wrote: > On Thu, 20 Aug 2009 12:17:36 +0200 > Jens Axboe <jens.axboe@oracle.com> wrote: > > > The O_DIRECT IO path is a mess of arguments. Clean that up by passing > > those arguments in a dedicated dio_args structure. > > > > This is in preparation for changing the internal implementation to be > > page based instead of using iovecs. > > > > ... > > > > +/* > > + * Arguments passwed to aops->direct_IO() > > cnat tpye
Ineedd, thanks.
> > + */ > > +struct dio_args { > > + int rw; > > + const struct iovec *iov; > > + unsigned long length; > > + loff_t offset; > > + unsigned long nr_segs; > > +}; > > It would be nice to have some documentation. Especially for that > pestiferous `rw' thing. > > nr_segs is associated with the iovec and might as well be contiguous > with it in the struct.
Agree on both accounts, I'll add some comment above/inside that struct.
-- Jens Axboe
| |