lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip] v3 Simplify rcu_pending()/rcu_check_callbacks() API
From
Date
On Sat, 2009-08-22 at 13:56 -0700, Paul E. McKenney wrote:
> From: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> All calls from outside RCU are of the form:
>
> if (rcu_pending(cpu))
> rcu_check_callbacks(cpu, user);
>
> This is silly, instead we put a call to rcu_pending() in
> rcu_check_callbacks(),

It could be non-silly if rcu_pending() were a very simple inline
function, in that case it would avoid the full function call.

Still in such a case you can make rcu_check_callbacks() the inline
function which does the same and have the real function called somthing
else.

Anyway, its all moot since rcu_pending() wasn't a simple inline function
anyway, so you've replaced two function calls with one, which seems
good.


\
 
 \ /
  Last update: 2009-08-24 09:13    [W:0.162 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site