Messages in this thread | | | Date | Mon, 24 Aug 2009 12:42:39 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] doc/rbtree: fix inserting example |
| |
On Sun, 23 Aug 2009 20:34:23 +0200 Marcin Slusarz wrote:
> rb_link_node and rb_insert_color take pointer to struct rb_node > as a first parameter, but example code passes plain struct rb_node. > Fix it.
This is already corrected in the mainline kernel tree, right?
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com> > Cc: Rob Landley <rob@landley.net> > Cc: Randy Dunlap <rdunlap@xenotime.net> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > Documentation/rbtree.txt | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/rbtree.txt b/Documentation/rbtree.txt > index 7224459..b67a87e 100644 > --- a/Documentation/rbtree.txt > +++ b/Documentation/rbtree.txt > @@ -131,8 +131,8 @@ Example: > } > > /* Add new node and rebalance tree. */ > - rb_link_node(data->node, parent, new); > - rb_insert_color(data->node, root); > + rb_link_node(&data->node, parent, new); > + rb_insert_color(&data->node, root); > > return TRUE; > }
--- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/
| |