lkml.org 
[lkml]   [2009]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/7] libata: use lazy workqueues for the pio task
On 08/24/2009 03:56 AM, Jens Axboe wrote:
> Signed-off-by: Jens Axboe<jens.axboe@oracle.com>
> ---
> drivers/ata/libata-core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
> index 072ba5e..35f74c9 100644
> --- a/drivers/ata/libata-core.c
> +++ b/drivers/ata/libata-core.c
> @@ -6580,7 +6580,7 @@ static int __init ata_init(void)
> {
> ata_parse_force_param();
>
> - ata_wq = create_workqueue("ata");
> + ata_wq = create_lazy_workqueue("ata");
> if (!ata_wq)
> goto free_force_tbl;

No objections to the code, operationally...

But it is disappointing that the "1 thread on UP" problem is not solved
while changing this libata area. Is there no way to specify a minimum
lazy-thread count?

A key problem continues to be tying to the number of CPUs, which is
quite inappropriate for libata.

Jeff





\
 
 \ /
  Last update: 2009-08-24 18:35    [from the cache]
©2003-2011 Jasper Spaans