Messages in this thread | | | Date | Sun, 23 Aug 2009 19:50:07 -0700 (PDT) | Subject | Re: [PATCH 2/2] drivers/net: fixed drivers that support netpoll use ndo_start_xmit() | From | David Miller <> |
| |
From: DDD <Dongdong.deng@windriver.com> Date: Fri, 21 Aug 2009 21:34:53 +0800
> The NETPOLL API requires that interrupts remain disabled in > netpoll_send_skb(). The use of "A functions set" in the NETPOLL API > callbacks causes the interrupts to get enabled and can lead to kernel > instability. > > The solution is to use "B functions set" to prevent the irqs from > getting enabled while in netpoll_send_skb(). > > A functions set: > local_irq_disable()/local_irq_enable() > spin_lock_irq()/spin_unlock_irq() > spin_trylock_irq()/spin_unlock_irq() > > B functions set: > local_irq_save()/local_irq_restore() > spin_lock_irqsave()/spin_unlock_irqrestore() > spin_trylock_irqsave()/spin_unlock_irqrestore() > > Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
Applied.
| |