Messages in this thread | | | Date | Sun, 23 Aug 2009 18:56:17 -0700 (PDT) | Subject | Re: [PATCH 1/1] NET: llc, zero sockaddr_llc struct | From | David Miller <> |
| |
From: Jiri Slaby <jirislaby@gmail.com> Date: Sat, 22 Aug 2009 20:58:55 +0200
> sllc_arphrd member of sockaddr_llc might not be set. Zero sllc > before copying it to the above layers. > > Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
I know it seems arbitrary, but could you please memset() on the structure instead of using an empty initializer so that it's consistent with how all other ->getname() implementations deal with this issue?
It's easier to audit that way.
Thanks.
| |