lkml.org 
[lkml]   [2009]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/2] ISDN: eicon, return on error
    Date
    When diva_strace_read_uint returns an error, return even from
    process_idi_event, because l2_state is uninitialized.

    Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
    ---
    drivers/isdn/hardware/eicon/maintidi.c | 5 +++--
    1 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/isdn/hardware/eicon/maintidi.c b/drivers/isdn/hardware/eicon/maintidi.c
    index 23960cb..41c26e7 100644
    --- a/drivers/isdn/hardware/eicon/maintidi.c
    +++ b/drivers/isdn/hardware/eicon/maintidi.c
    @@ -959,8 +959,9 @@ static int process_idi_event (diva_strace_context_t* pLib,
    }
    if (!strncmp("State\\Layer2 No1", path, pVar->path_length)) {
    char* tmp = &pLib->lines[0].pInterface->Layer2[0];
    - dword l2_state;
    - diva_strace_read_uint (pVar, &l2_state);
    + dword l2_state;
    + if (diva_strace_read_uint(pVar, &l2_state))
    + return -1;

    switch (l2_state) {
    case 0:
    --
    1.6.3.3


    \
     
     \ /
      Last update: 2009-08-22 20:45    [W:0.019 / U:0.980 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site