lkml.org 
[lkml]   [2009]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC patch 02/32] x86: Add probe_roms to platform_setup
    On Fri, 21 Aug 2009, Jeremy Fitzhardinge wrote:

    > On 08/21/09 14:29, Thomas Gleixner wrote:
    > [argh attachments]

    No. :)

    Content-Disposition: inline;
    filename=x86-add-probe-roms-to-platform-setup.patch

    > > probe_roms is only used on 32bit. Add it to the platform_setup code
    > > and remove the #ifdefs.
    > >
    > > Default initializer is platform_setup_noop() which is overridden in
    > > the 32bit boot code.
    > >
    > >
    >
    > I realize you're aiming to make this transform have no functional
    > side-effects, but is there a good reason why probe_roms *couldn't* be
    > done in 64-bit? It seems to me that its useful for coverage
    > completeness to have the 32 and 64 bit do the same thing even if its
    > sometimes redundant.

    Yes. I aimed for functional equivilance in the first place and this is
    a RFC so any improvements are welcome.

    Thanks,

    tglx


    \
     
     \ /
      Last update: 2009-08-22 00:41    [W:0.019 / U:0.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site