Messages in this thread Patch in this message | | | From | Andy Whitcroft <> | Subject | [PATCH 1/7] checkpatch: possible types -- else cannot start a type | Date | Fri, 21 Aug 2009 22:46:04 +0100 |
| |
An else cannot start a type, it would have to be within a block after the else. This can trigger false modifier matching.
Signed-off-by: Andy Whitcroft <apw@canonical.com> --- scripts/checkpatch.pl | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 2d5ece7..fd64816 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1372,6 +1372,8 @@ sub process { # Ignore functions being called } elsif ($s =~ /^.\s*$Ident\s*\(/s) { + } elsif ($s =~ /^.\s*else\b/s) { + # declarations always start with types } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) { my $type = $1; -- 1.6.3.3
| |