Messages in this thread | | | Date | Fri, 21 Aug 2009 22:09:08 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86: properly annotate alternatives.c |
| |
* Jan Beulich <JBeulich@novell.com> wrote:
> Some of the NOPs tables aren't used on 64-bits, quite some code and > data is needed post-init for module loading only, and a couple of > functions aren't used outside that file (i.e. can be static, and don't > need to be exported). > > The change to __INITDATA/__INITRODATA is needed to avoid an assembler > warning. > > Signed-off-by: Jan Beulich <jbeulich@novell.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > > --- > arch/x86/include/asm/alternative.h | 7 ---- > arch/x86/kernel/alternative.c | 56 +++++++++++++++++++++---------------- > include/linux/init.h | 12 ++++++- > 3 files changed, 42 insertions(+), 33 deletions(-)
looks like a nice improvement. Sam, what do you think?
Ingo
| |