lkml.org 
[lkml]   [2009]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perfcounters/tracing] perf trace: Add OPT_END to option array of perf-trace
    Commit-ID:  1909629fb1ec9800cf2cb0091870d6a1c1ca665f
    Gitweb: http://git.kernel.org/tip/1909629fb1ec9800cf2cb0091870d6a1c1ca665f
    Author: Masami Hiramatsu <mhiramat@redhat.com>
    AuthorDate: Fri, 21 Aug 2009 14:56:03 -0400
    Committer: Ingo Molnar <mingo@elte.hu>
    CommitDate: Fri, 21 Aug 2009 21:42:43 +0200

    perf trace: Add OPT_END to option array of perf-trace

    Add OPT_END to option array of perf-trace for fixing a SEGV bug when
    showing perf-trace help message.

    Without this patch;
    ./perf trace -h

    usage: perf trace [<options>] <command>

    -D, --dump-raw-trace dump raw trace in ASCII
    -v, --verbose be more verbose (show symbol address, etc)
    -f, Segmentation fault

    With this patch:
    ./perf trace -h

    usage: perf trace [<options>] <command>

    -D, --dump-raw-trace dump raw trace in ASCII
    -v, --verbose be more verbose (show symbol address, etc)

    Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
    Cc: systemtap <systemtap@sources.redhat.com>
    Cc: DLE <dle-develop@lists.sourceforge.net>
    Cc: Masami Hiramatsu <mhiramat@redhat.com>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
    Cc: Mike Galbraith <efault@gmx.de>
    Cc: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
    Cc: Zhaolei <zhaolei@cn.fujitsu.com>
    Cc: Li Zefan <lizf@cn.fujitsu.com>
    Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
    Cc: Tom Zanussi <tzanussi@gmail.com>
    LKML-Reference: <20090821185603.11039.62109.stgit@localhost.localdomain>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>


    ---
    tools/perf/builtin-trace.c | 1 +
    1 files changed, 1 insertions(+), 0 deletions(-)

    diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
    index 88eef71..dd3c2e7 100644
    --- a/tools/perf/builtin-trace.c
    +++ b/tools/perf/builtin-trace.c
    @@ -257,6 +257,7 @@ static const struct option options[] = {
    "dump raw trace in ASCII"),
    OPT_BOOLEAN('v', "verbose", &verbose,
    "be more verbose (show symbol address, etc)"),
    + OPT_END()
    };

    int cmd_trace(int argc, const char **argv, const char *prefix __used)

    \
     
     \ /
      Last update: 2009-08-21 21:49    [W:0.025 / U:60.348 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site