lkml.org 
[lkml]   [2009]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH,v2] Re: e1000e: why does pci_enable_pcie_error_reporting() fail on my hp2510p?
    From
    Date
    On Fri, 2009-08-21 at 08:48 +0200, Frans Pop wrote:
    [...]
    > @@ -5301,9 +5296,6 @@ static void __devexit e1000_remove(struct pci_dev *pdev)
    >
    > /* AER disable */
    > err = pci_disable_pcie_error_reporting(pdev);
    > - if (err)
    > - dev_err(&pdev->dev,
    > - "pci_disable_pcie_error_reporting failed 0x%x\n", err);
    >
    > pci_disable_device(pdev);
    > }

    While you're at it, why don't you also remove the "err =" here, which
    allows you to drop the variable from that function completely? This
    applies to all three *_remove() functions.



    \
     
     \ /
      Last update: 2009-08-21 09:09    [W:0.019 / U:66.380 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site