Messages in this thread | | | Date | Fri, 21 Aug 2009 16:39:18 +0200 | From | Ingo Molnar <> | Subject | Re: [Patch] x86: fix a wrong argument of reserve_bootmem() |
| |
* Amerigo Wang <amwang@redhat.com> wrote:
> This line looks suspicious, because if this is true, then the > 'flags' parameter of function reserve_bootmem_generic() will be > unused when !CONFIG_NUMA. I don't think this is what we want. > > Signed-off-by: WANG Cong <amwang@redhat.com> > Cc: Ingo Molnar <mingo@elte.hu> > Cc: Yinghai Lu <yinghai@kernel.org> > > --- > diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c > index 6176fe8..ea56b8c 100644 > --- a/arch/x86/mm/init_64.c > +++ b/arch/x86/mm/init_64.c > @@ -796,7 +796,7 @@ int __init reserve_bootmem_generic(unsigned long phys, unsigned long len, > return ret; > > #else > - reserve_bootmem(phys, len, BOOTMEM_DEFAULT); > + reserve_bootmem(phys, len, flags);
Yes, this looks like an oversight. Since it only affected 32-bit NUMA materially, which is quite rare, it probably didnt matter that much but should be fixed ...
Ingo
| |