Messages in this thread | | | Date | Fri, 21 Aug 2009 02:32:32 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH] x86: add /proc/cpuinfo/physical id quirks |
| |
> I agree... if this ID is used for topology detection, we shouldn't > replace it arbitrarily with information from BIOS just to hope that it > matches the motherboard stencil. *Furthermore*, there is no reason why > motherboard stencilAs are purely numeric... consider the rather obvious > case of two rows of four CPUs; they may have CPU slots labelled A1, A2, > A3, A4, B1, B2, B3, B4. It might very well be the right thing to > support arbitrary strings for platforms we recognize.
Maintaining a manual mapping to strings in the kernel to such strings would be just crazy. You would need a new entry for basically every system.
The reason to correct SOCKETID is that it it is output on errors. If it is numerical and you know it's wrong you can correct it, and then you can identify the right CPU. Otherwise you lose.
-Andi -- ak@linux.intel.com -- Speaking for myself only.
| |