Messages in this thread | | | Date | Thu, 20 Aug 2009 18:11:47 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 4/7] kfifo: rename kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out... |
| |
On Wed, Aug 19, 2009 at 02:03:39PM -0700, Joe Perches wrote: > On Wed, 2009-08-19 at 23:00 +0200, Stefani Seibold wrote: > > rename kfifo_put... into kfifo_in... to prevent miss use of old non in kernel-tree drivers > > ditto for kfifo_get... -> kfifo_out... > > I would have thought > kfifo_put -> kfifo_out > kfifo_get -> kfifo_in > but maybe that's just me.
I don't think it's fruitful to criticize other people's variable names. The rule in Linux is normally: if you write the code you get to name it the way you want.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |