Messages in this thread Patch in this message |  | | Date | Sun, 02 Aug 2009 13:43:11 +0200 | From | Roel Kluin <> | Subject | [PATCH] perf: Read buffer overflow |
| |
Check whether index is within bounds before testing the element.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index b20a4b6..edecdbe 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -252,7 +252,7 @@ static int strcommon(const char *pathname) { int n = 0; - while (pathname[n] == cwd[n] && n < cwdlen) + while (n < cwdlen && pathname[n] == cwd[n]) ++n; return n; diff --git a/tools/perf/util/quote.c b/tools/perf/util/quote.c index c6e5dc0..2726fe4 100644 --- a/tools/perf/util/quote.c +++ b/tools/perf/util/quote.c @@ -318,7 +318,7 @@ char *quote_path_relative(const char *in, int len, strbuf_addch(out, '"'); if (prefix) { int off = 0; - while (prefix[off] && off < len && prefix[off] == in[off]) + while (off < len && prefix[off] && prefix[off] == in[off]) if (prefix[off] == '/') { prefix += off + 1; in += off + 1;
|  |