Messages in this thread | | | Date | Wed, 19 Aug 2009 09:57:14 +0100 | From | Mel Gorman <> | Subject | Re: [PATCH 1/3] page-allocator: Split per-cpu list into one-list-per-migrate-type |
| |
On Tue, Aug 18, 2009 at 03:57:00PM -0700, Vincent Li wrote: > On Tue, 18 Aug 2009, Mel Gorman wrote: > > > + /* > > + * We only track unreclaimable, reclaimable and movable on pcp lists. > ^^^^^^^^^^^^^ > Is it unmovable? I don't see unreclaimable migrate type on pcp lists. > Just ask to make sure I undsterstand the comment right. >
It should have said unmovable. Sorry
> > + * Free ISOLATE pages back to the allocator because they are being > > + * offlined but treat RESERVE as movable pages so we can get those > > + * areas back if necessary. Otherwise, we may have to free > > + * excessively into the page allocator > > + */ > > + if (migratetype >= MIGRATE_PCPTYPES) { > > + if (unlikely(migratetype == MIGRATE_ISOLATE)) { > > + free_one_page(zone, page, 0, migratetype); > > + goto out; > > + } > > + migratetype = MIGRATE_MOVABLE; > > + } > > + > > Vincent Li > Biomedical Research Center > University of British Columbia >
-- Mel Gorman Part-time Phd Student Linux Technology Center University of Limerick IBM Dublin Software Lab
| |