lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] page-allocator: Split per-cpu list into one-list-per-migrate-type
On Tue, Aug 18, 2009 at 03:57:00PM -0700, Vincent Li wrote:
> On Tue, 18 Aug 2009, Mel Gorman wrote:
>
> > + /*
> > + * We only track unreclaimable, reclaimable and movable on pcp lists.
> ^^^^^^^^^^^^^
> Is it unmovable? I don't see unreclaimable migrate type on pcp lists.
> Just ask to make sure I undsterstand the comment right.
>

It should have said unmovable. Sorry

> > + * Free ISOLATE pages back to the allocator because they are being
> > + * offlined but treat RESERVE as movable pages so we can get those
> > + * areas back if necessary. Otherwise, we may have to free
> > + * excessively into the page allocator
> > + */
> > + if (migratetype >= MIGRATE_PCPTYPES) {
> > + if (unlikely(migratetype == MIGRATE_ISOLATE)) {
> > + free_one_page(zone, page, 0, migratetype);
> > + goto out;
> > + }
> > + migratetype = MIGRATE_MOVABLE;
> > + }
> > +
>
> Vincent Li
> Biomedical Research Center
> University of British Columbia
>

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab


\
 
 \ /
  Last update: 2009-08-19 10:59    [W:0.066 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site