lkml.org 
[lkml]   [2009]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/10] x86/boot: add setup_secondary_clock to x86 quirk
Jacob,

On Thu, 16 Jul 2009, Pan, Jacob jun wrote:

> >From 8d2ba963b3f352ee478fda838422425aaed0a97a Mon Sep 17 00:00:00 2001
> From: Jacob Pan <jacob.jun.pan@intel.com>
> Date: Tue, 9 Jun 2009 17:02:48 -0700
> Subject: [PATCH] x86/boot: add setup_secondary_clock to x86 quirk
>
> Some x86 platform such as Intel Moorestown use external timers for per
> cpu clockevent devices. This quirk is added such as we can override the
> default local APIC timers if such platform is detected.
>
> Should not have impact on other platforms that uses default or platform
> specific x86_quirks.

That patch is only half of the story. What about the apic timer setup
of the primary CPU ?

Also we already have paravirt ops overriding the clock setup for boot
and secondary cpus. Your patch adds another level of indirection.
That's just a nightmare.

The correct approach is to clean up the clock setup in general and get
rid of the paravirt indirection. There is no reason why paravirt
guests should not use the same infrastructure as we need for platform
support.

I need to think more about how it should look, but we definitely want
something which is of general use and does not just add extra
conditinal stuff.

Thanks,

tglx


\
 
 \ /
  Last update: 2009-08-19 16:43    [from the cache]
©2003-2011 Jasper Spaans