Messages in this thread | | | Date | Tue, 18 Aug 2009 10:35:48 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] splice: update mtime and atime on files |
| |
On Tue, Aug 18 2009, Willy Tarreau wrote: > On Sat, Aug 15, 2009 at 08:42:41AM +0200, Jens Axboe wrote: > > On Fri, Aug 14 2009, Miklos Szeredi wrote: > > > From: Miklos Szeredi <mszeredi@suse.cz> > > > > > > Splice should update the modification and access times on regular > > > files just like read and write. Not updating mtime will confuse > > > backup tools, etc... > > > > > > This patch only adds the time updates for regular files. For pipes > > > and other special files that splice touches the need for updating the > > > times is less clear. Let's discuss and fix that separately. > > > > Thanks Miklos, I've queued this one up. > > wouldn't it make sense to send that to stable too ? The patch is not > intrusive and looks like a fix to me.
It doesn't really meet the stable criteria, as it's not a security issue nor does it crash the kernel.
-- Jens Axboe
| |