lkml.org 
[lkml]   [2009]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] replace various uses of num_physpages by totalram_pages

* Jan Beulich <JBeulich@novell.com> wrote:

> Sizing of memory allocations shouldn't depend on the number of
> physical pages found in a system, as that generally includes
> (perhaps a huge amount of) non-RAM pages. The amount of what
> actually is usable as storage should instead be used as a basis
> here.
>
> Some of the calculations (i.e. those not intending to use high
> memory) should likely even use (totalram_pages -
> totalhigh_pages).
>
> Signed-off-by: Jan Beulich <jbeulich@novell.com>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
>
> ---
> arch/x86/kernel/microcode_core.c | 4 ++--

Acked-by: Ingo Molnar <mingo@elte.hu>

Just curious: how did you find this bug? Did you find this by
experiencing problems on a system with a lot of declared non-RAM
memory?

Ingo


\
 
 \ /
  Last update: 2009-08-18 17:41    [W:0.025 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site