lkml.org 
[lkml]   [2009]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/24] blkio_cgroup patches from Ryo to track async bios.
On Tue, Aug 18, 2009 at 08:42:12PM +0900, Ryo Tsuruta wrote:
> Hi Vivek,
>
> Vivek Goyal <vgoyal@redhat.com> wrote:
> > o blkio_cgroup patches from Ryo to track async bios.
> >
> > o Fernando is also working on another IO tracking mechanism. We are not
> > particular about any IO tracking mechanism. This patchset can make use
> > of any mechanism which makes it to upstream. For the time being making
> > use of Ryo's posting.
>
> The patch attached with your mail is obsolete and it may potentially
> cause a deadlock when lock_page_cgroup() is called under radix_tree->lock.
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=e767e0561d7fd2333df1921f1ab4176211f9036b
>
> The latest blkio-cgroup fixes the above issue and reduces IO tracking
> overhead since lock_page_cgroup() is no longer used. I would recommend
> to update to the latest version.
>

Hi Ryo,

Thanks. In next posting I will move to latest version of io tracking
patches.

> And I have a suggestion, how about moving get_cgroup_from_page() to
> biotrack.c, I think this function would be useful for people who
> want to make use of the IO tracking mechanism.
>
> Please let me know your opinion.

Makes sense. In next posting, will move get_cgroup_from_page() to biotrack.c.

Thanks
Vivek


\
 
 \ /
  Last update: 2009-08-18 16:29    [W:0.032 / U:13.616 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site