lkml.org 
[lkml]   [2009]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [regression, bisected] fails to boot on Dell Optiplex 760 with VT-d enabled
Chris Wright wrote:
> AFAIK, this platform is broken when VT-d is enabled.
> Can you add this patch to a broken kernel and retest?
> Please boot with 'debug' on the kernel command line.
Thanks but David was faster, we've already established that

http://git.infradead.org/iommu-2.6.git/commit/0815565a

which is, as far as I can understand, very similar to your patch, indeed
fixes the issue.

> + if (ver == (u32)-1 || iommu->cap == (u64)-1 || iommu->ecap == (u64)-1) {
As an observation, David's patch is checking if *both* iommu->cap and
iommu->ecap are -1, while yours checks for either. You're also checking
for ver. Obviously, I have no idea which of the two is more correct.

Thanks,
Faidon


\
 
 \ /
  Last update: 2009-08-18 01:25    [W:0.400 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site